[PATCH]Remove the redundant assignment - Mailing list pgsql-hackers

From Feilong Meng
Subject [PATCH]Remove the redundant assignment
Date
Msg-id tencent_771178777C5BC17FCB7F7A1771CD1FFD5708@qq.com
Whole thread Raw
Responses Re: [PATCH]Remove the redundant assignment
List pgsql-hackers
Hi,Hackers,

I found that in the InjectionPointAttach function within the src/backend/utils/misc/injection_point.c file, the
variableis manually assigned a '\0' at the end, even though strlcpy already guarantees that the destination buffer will
benull-terminated and will not overflow. 

The code modification is as follows:

```
/* Save the entry */
strlcpy(entry->name, name, sizeof(entry->name));
entry->name[INJ_NAME_MAXLEN - 1] = '\0';  <== Delete this line
strlcpy(entry->library, library, sizeof(entry->library));
entry->library[INJ_LIB_MAXLEN - 1] = '\0';  <== Delete this line
strlcpy(entry->function, function, sizeof(entry->function));
entry->function[INJ_FUNC_MAXLEN - 1] = '\0';  <== Delete this line
```

And in the injection_point_cache_add function within the same file, strlcpy(entry->name, name, sizeof(entry->name));
doesnot perform redundant assignment. 

I have tested the change, and "make check" passed.



--------------

Best regards,


Feilong Meng



Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Fix crash during recovery when redo segment is missing
Next
From: Peter Smith
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart