Re: Handle concurrent drop when doing whole database vacuum - Mailing list pgsql-hackers

From cca5507
Subject Re: Handle concurrent drop when doing whole database vacuum
Date
Msg-id tencent_76660EEFFE00C04E29D4A3D0AC9638854E05@qq.com
Whole thread
In response to Re: Handle concurrent drop when doing whole database vacuum  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: Handle concurrent drop when doing whole database vacuum
List pgsql-hackers
Hi,

> > FWIW, even after sleeping on it, I don't think that this patch is
> > going in the right direction.  I am pretty sure that we should just
> > lift the ACL check in get_all_vacuum_rels() and always require
> > vacuum_is_permitted_for_relation() to have the relation locked when
> > called.  This way we would rely on one single code path for the ACL
> > check, even if it means holding a reference of a relation OID for
> > something to be processsed later.  So I would revisit the choice made
>
> FWIW, I agree with this direction.

This direction is also OK for me. We might want to fix get_tables_to_repack()
together?

--
Regards,
ChangAo Chen

pgsql-hackers by date:

Previous
From: Vitaly Davydov
Date:
Subject: Re: Deadlock detector fails to activate on a hot standby replica
Next
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication