Re: Speed up ICU case conversion by using ucasemap_utf8To*() - Mailing list pgsql-hackers

From zengman
Subject Re: Speed up ICU case conversion by using ucasemap_utf8To*()
Date
Msg-id tencent_3C4ABC775EDA640F219A5E69@qq.com
Whole thread Raw
In response to Re: Speed up ICU case conversion by using ucasemap_utf8To*()  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: Speed up ICU case conversion by using ucasemap_utf8To*()
List pgsql-hackers
> Here is a version 4 of the patch which uses the fact that we have method
> tables to remove one level of indirection. I am not sure the extra lines
> of codes are worth it but on the other hand despite 40 more lines the
> code became easier to read to me. What do you think?

I don't have any major objections, but I noticed a few minor details that might need a bit more tweaking.

`signficant`  -> `significant`
`realtively`  ->  `relatively`
`if (status != U_BUFFER_OVERFLOW_ERROR && U_FAILURE(status))` -> `if (U_FAILURE(status) && status !=
U_BUFFER_OVERFLOW_ERROR)`


--
Regards,
Man Zeng
www.openhalo.org

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Bug in amcheck?
Next
From: Thomas Munro
Date:
Subject: Re: LLVM JITLink attempt II (WIP)