Re: [PATCH] aio: Refactor to deduplicate shared and local completion callbacks - Mailing list pgsql-hackers

From zengman
Subject Re: [PATCH] aio: Refactor to deduplicate shared and local completion callbacks
Date
Msg-id tencent_118EBB44338AE1F742F8ADC4@qq.com
Whole thread Raw
In response to Re: [PATCH] aio: Refactor to deduplicate shared and local completion callbacks  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
> It doesn't really seem to improve things sufficiently for my taste. If you
> don't remove comments that are actually important, like "Note that we don't
> save the result", the code doesn't even get shorter. And it's not like the
> function afterwards is more generic, since it encodes all the knowledge about
> the different callback kinds.

Thanks for the feedback. I’ll think of a better approach.
Thanks for the guidance.

--
Regards,
Man Zeng
www.openhalo.org

pgsql-hackers by date:

Previous
From: Srirama Kucherlapati
Date:
Subject: RE: AIX support
Next
From: "Jelte Fennema-Nio"
Date:
Subject: Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore