Re: [PATCH] Precompute string lengths in PerformRadiusTransaction - Mailing list pgsql-hackers

From zengman
Subject Re: [PATCH] Precompute string lengths in PerformRadiusTransaction
Date
Msg-id tencent_02123DD614E78E272ECC556A@qq.com
Whole thread Raw
In response to Re: [PATCH] Precompute string lengths in PerformRadiusTransaction  (John Naylor <johncnaylorls@gmail.com>)
List pgsql-hackers
> > I noticed that the `PerformRadiusTransaction` function is invoked in a loop,
> > and the function itself contains internal loops that repeatedly call strlen() on the 'passwd' and 'secret'
strings.
> > While the optimization gain may be minimal, I still think it’s worth making the change —
> > we can precompute the lengths of these two strings at the start of the function to eliminate redundant strlen()
calls.
> 
> Shortly after you posted this, it was decided that we're going to
> remove this method entirely:
> 
> https://wiki.postgresql.org/wiki/RADIUS
Hi,

Okay, thank you very much for reminding me. I'll retract this patch.

--
regards,
Man Zeng

pgsql-hackers by date:

Previous
From: Ed Behn
Date:
Subject: Re: access numeric data in module
Next
From: John Naylor
Date:
Subject: Re: Lowering the default wal_blocksize to 4K