Re: remove pg_restrict workaround - Mailing list pgsql-hackers

From Andres Freund
Subject Re: remove pg_restrict workaround
Date
Msg-id t7c3shj2mdo7wtwmxgt32rv66qcypnp5blys5skqlem7j5ua5h@kunmzc77aebb
Whole thread Raw
In response to Re: remove pg_restrict workaround  (Jelte Fennema-Nio <postgres@jeltef.nl>)
List pgsql-hackers
Hi,

On 2026-01-03 00:23:37 +0100, Jelte Fennema-Nio wrote:
> On Wed, 29 Oct 2025 at 08:04, Peter Eisentraut <peter@eisentraut.org> wrote:
> > Committed with a backward compatibility define.
> 
> I'm working on adding a C++ extension module to my copyObject
> patchset[1]. But turns out that this change has completely broken
> compiling C++ extensions on MSVC. This is happening due to
> __declspec(restrict) being replaced by __declspec(__restrict), which
> the original comments also mentioned as the reason for having our own
> flavor. This replacement then makes the core of a corecrt_malloc.h
> MSVC header invalid[2].
> 
> So I think we should revert this patch.

+1

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded
Next
From: Peter Eisentraut
Date:
Subject: Re: some Page/PageData const stuff