Hi,
On 2025-06-30 15:49:49 +0900, Michael Paquier wrote:
> On Wed, Jun 25, 2025 at 10:21:03AM -0500, Nathan Bossart wrote:
> > On Wed, Jun 25, 2025 at 10:31:35AM +0900, Michael Paquier wrote:
> >> Attached is the remaining patch for HEAD, planned once v19 opens, and
> >> the tests I have used on the back-branches as a txt to not confuse the
> >> CI, for reference.
> >
> > Looks reasonable to me.
>
> Thanks. Applied on HEAD, then.
I was just looking at the includes for tableam.h - a quite widely included
header - and got rather sad seeing vacuum.h in there, as it has a quite large
dependency tree and tableam.h is obviously widely included.
I was surprised that I would have added such a wide include when working on
tableam. Turns out I hadn't - it was 2252fcd4276c.
I think this change was quite ill considered. Look at the dependency tree of
vacuum.h:
https://doxygen.postgresql.org/vacuum_8h.html
That's a *lot* of headers to pull into something as widely included as
tableam.h
Why wasn't it enough to add const markers and keep passing by pointer?
Greetings,
Andres
