Re: Annoying warning in SerializeClientConnectionInfo - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Annoying warning in SerializeClientConnectionInfo
Date
Msg-id ru22zkposrpvopmgkaejafl2izv4jzc7jr6f6hh3efrnucivkp@idaumq7jjhkm
Whole thread Raw
In response to Re: Annoying warning in SerializeClientConnectionInfo  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Annoying warning in SerializeClientConnectionInfo
List pgsql-hackers
Hi,

On 2025-08-13 12:54:27 +0900, Michael Paquier wrote:
> > I think the PG_USED_FOR_ASSERTS_ONLY fix is preferable for backport,
> > so I don't want to get in the way of that approach.
> 
> The attached has been working for me.  Thoughts?

I think we shouldn't add the attribute to the declaration, just to the
function. The caller doesn't need to know that it's unused, it's purely a
question of the specific implementation that the attribute is unused.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: meson: Add _static and _shared suffixes to the library names
Next
From: Tom Lane
Date:
Subject: Re: cfbot mistakenly reports that a rebase is needed