Re: [PG19][PATCH] Make postgres_fdw statistics import atomic - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PG19][PATCH] Make postgres_fdw statistics import atomic
Date
Msg-id rjuaaeih3zniuoz5yoae7wwdobko5smqh5ytoudyish7udwtjz@rbtoai4kbc4r
Whole thread
In response to Re: [PG19][PATCH] Make postgres_fdw statistics import atomic  (Corey Huinker <corey.huinker@gmail.com>)
Responses Re: [PG19][PATCH] Make postgres_fdw statistics import atomic
List pgsql-hackers
Hi,

On 2026-09-16 16:45:26 -0400, Corey Huinker wrote:
> And how would the first foreign table handle this if we fixed the records
> in a way that didn't also leave the table empty?
> 
>     # UPDATE remote_t SET b = 4;
>     UPDATE 2
>     # analyze ft;
>     WARNING:  invalid input syntax for type integer: "bad-x"
>     WARNING:  could not import statistics for foreign table "public.ft" ---
> attribute statistics import failed for column "b" of this foreign table

What is the defense of making all these warnings rather than errors?  It's one
thing to e.g. warn that analyze skipped a relation due to locks, but doing
some catalog updates but not doing everything that the catalog updates
depended on seems like a really bad idea.  Transactions exist for a reason...

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Regression tests failures due to concurrent grants
Next
From: Andres Freund
Date:
Subject: Re: Regression tests failures due to concurrent grants