Re: plpython improvements - Mailing list pgsql-patches

From Sven Suursoho
Subject Re: plpython improvements
Date
Msg-id op.s8tuyvmcplgmb3@localhost
Whole thread Raw
In response to Re: plpython improvements  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: plpython improvements  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Hi,


Thu, 27 Apr 2006 17:17:36 +0300, Bruce Momjian <pgman@candle.pha.pa.us>:

> Sorry, I have to revert this patch because it is causing crashes in the
> plpython regression tests.  Would you please run those tests, fix the
> bug, and resubmit.  Thanks.

Found and fixed two problems:
1) named parameters handling if there were no parameters at all
2) didn't increment counter for borrowed reference fetched from list

Also integrated tests to plpython test suite and updated existing tests to
use named parameters.

Unfortunately, there is still one problem when using unpatched python,
caused by too aggressive assert.
See
http://mail.python.org/pipermail/python-checkins/2005-August/046571.html.
I guess there should be warning somewhere as Hannu said but didn't know
where to put it.


--
Sven Suursoho

Attachment

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: pgstat: delayed write of stats file
Next
From: Tom Lane
Date:
Subject: Re: plpython improvements