Re: VM corruption on standby - Mailing list pgsql-hackers

From Andres Freund
Subject Re: VM corruption on standby
Date
Msg-id nhzwd7ae2lasqoadikbq5jhnaejzlqxpwmcmq3il4vtdzozv35@xtzxftuovbyo
Whole thread Raw
In response to Re: VM corruption on standby  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: VM corruption on standby
List pgsql-hackers
Hi,

On 2025-08-20 02:54:09 +1200, Thomas Munro wrote:
> > On linux - the primary OS with OOM killer troubles - I'm pretty sure'll lwlock
> > waiters would get killed due to the postmaster death signal we've configured
> > (c.f. PostmasterDeathSignalInit()).
> 
> No, that has a handler that just sets a global variable.  That was
> done because recovery used to try to read() from the postmaster pipe
> after replaying every record.  Also we currently have some places that
> don't want to be summarily killed (off the top of my head, syncrep
> wants to send a special error message, and the logger wants to survive
> longer than everyone else to catch as much output as possible, things
> I've been thinking about in the context of threads).

That makes no sense. We should just _exit(). If postmaster has been killed,
trying to stay up longer just makes everything more fragile. Waiting for the
logger is *exactly* what we should *not* do - what if the logger also crashed?
There's no postmaster around to start it.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: VM corruption on standby
Next
From: Laurenz Albe
Date:
Subject: Re: analyze-in-stages post upgrade questions