Postgres Pro
Downloads
Home   >   mailing lists

[PATCH] Improve safety of FormatMessage() calls on Windows - Mailing list pgsql-hackers

From Christian Ullrich
Subject [PATCH] Improve safety of FormatMessage() calls on Windows
Date
Msg-id nddv2g$tr1$1@ger.gmane.org
Whole thread Raw
Responses Re: [PATCH] Improve safety of FormatMessage() calls on Windows
List pgsql-hackers
Tree view 
There are some instances of calls to FormatMessage() with the 
FORMAT_MESSAGE_FROM_SYSTEM flag that omit the 
FORMAT_MESSAGE_IGNORE_INSERTS flag. The effect of that is that if the 
requested message string contains any insertion markers, the call to 
FormatMessage() will fail because none of these calls pass an argument list.

This patch adds the ...IGNORE_INSERTS flag to these calls.

The documentation for FormatMessage() does not clearly say that a NULL 
argument list is not an implicit IGNORE_INSERTS flag, but Chen does at 
<https://blogs.msdn.microsoft.com/oldnewthing/20071128-00/?p=24353>.

-- 
Christian

pgsql-hackers by date:

Previous
From: Anastasia Lubennikova
Date:
Subject: Re: [PATCH] Supporting +-Infinity values by to_timestamp(float8)
Next
From: David Steele
Date:
Subject: Re: [PATCH v8] GSSAPI encryption support