Re: ALTER TABLE ... NOREWRITE option - Mailing list pgsql-hackers

From Dimitri Fontaine
Subject Re: ALTER TABLE ... NOREWRITE option
Date
Msg-id m2wqwz4e1u.fsf@2ndQuadrant.fr
Whole thread Raw
In response to Re: ALTER TABLE ... NOREWRITE option  (Noah Misch <noah@leadboat.com>)
Responses Re: ALTER TABLE ... NOREWRITE option
Re: ALTER TABLE ... NOREWRITE option
List pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> Acquiring the lock could still take an unpredictable amount of time.

I think there's a new GUC brewing about setting the lock timeout
separately from the statement timeout, right?

> being said, I share Tom's doubts.  The DEBUG1 messages are a sorry excuse for
> a UI, but I'm not seeing a clear improvement in NOREWRITE.

EXPLAIN ALTER TABLE would be the next step I guess. I discovered plenty
of magic tricks when working on the rewriting support for that command,
and I think exposing them in the EXPLAIN output would go a long way
towards reducing some POLA violations.

Ideally the EXPLAIN command would include names of new objects created
by the command, such as constraints and indexes.

>> My first thought is to add more detailed EXPLAIN support for
>> DDL... Although that unfortunately broadens the scope of this a tiny
>> bit.
>
> That would be ideal.

+1

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support



pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: ALTER command reworks
Next
From: Simon Riggs
Date:
Subject: Re: Refactoring standby mode logic