Re: Completing PL support for Event Triggers - Mailing list pgsql-hackers

From Dimitri Fontaine
Subject Re: Completing PL support for Event Triggers
Date
Msg-id m2iouy76q8.fsf@2ndQuadrant.fr
Whole thread Raw
In response to Re: Completing PL support for Event Triggers  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Completing PL support for Event Triggers
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> I think this is wrong, and the reason it crashes if you remove it is
> that you need to call increment_prodesc_refcount(prodesc), like in the
> other handlers.

Thanks, looks like this indeed.

> Attached is my "final" patch.  Let me know if it's OK for you.

It looks like you started with the v1 of the plperl patch rather than
the v2, where the only difference is in only using is_trigger or using
both is_trigger and is_event_trigger. Your version currently uses both
where I though we chose using is_trigger only.

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support



pgsql-hackers by date:

Previous
From: Karsten Hilbert
Date:
Subject: Re: [GENERAL] pg_upgrade ?deficiency
Next
From: Heikki Linnakangas
Date:
Subject: Re: GIN improvements part 1: additional information