Postgres Pro
Downloads
Home   >   mailing lists

Re: Extensions, this time with a patch - Mailing list pgsql-hackers

From Dimitri Fontaine
Subject Re: Extensions, this time with a patch
Date
Msg-id m2aamakuod.fsf@2ndQuadrant.fr
Whole thread Raw
In response to Re: Extensions, this time with a patch  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Tree view 
Alvaro Herrera <alvherre@commandprompt.com> writes:
> The error message wording needs some work; maybe
>     errmsg("file \"%s\" could not be executed", filename)
[...]
> I happened to notice that there are several pieces of code that are
> calling SPI_connect and SPI_finish without checking the return value,
> notably the FTS code and xml.c.

Please find attached pg_execute_from_file.v4.patch with fixes. I've used
the usual error messages for SPI_connect() and finish this time.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support
Attachment

pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: max_wal_senders must die
Next
From: Dimitri Fontaine
Date:
Subject: Re: Extensions, this time with a patch