Re: Event Triggers reduced, v1 - Mailing list pgsql-hackers

From Dimitri Fontaine
Subject Re: Event Triggers reduced, v1
Date
Msg-id m2a9zlkddk.fsf@2ndQuadrant.fr
Whole thread Raw
In response to Re: Event Triggers reduced, v1  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Event Triggers reduced, v1  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> ../../../src/include/catalog/pg_event_trigger.h:34: error: expected
> specifier-qualifier-list before ‘int2’
>
> This needs to be changed to int16 as a result of commit
> b8b2e3b2deeaab19715af063fc009b7c230b2336.

Done as part of the previous work.

> alter.c:73: warning: implicit declaration of function ‘RenameEventTrigger’

Done now.

> Please spell out DO_EVTTRIGGER as DO_EVENT_TRIGGER.

Also done as part of the previous email.

> Another random warning:
> plpy_main.c:195: warning: ‘retval’ may be used uninitialized in this function

Will do a whole warning check pass later. Can you give me your local
Makefile trick to turn them into hard errors again please? :)

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: elog/ereport noreturn decoration
Next
From: Tom Lane
Date:
Subject: Re: change_varattnos_of_a_node versus whole-row Vars