Re: [HACKERS] Case statement ready? - Mailing list pgsql-hackers

From jwieck@debis.com (Jan Wieck)
Subject Re: [HACKERS] Case statement ready?
Date
Msg-id m0zmxPp-000EBPC@orion.SAPserv.Hamburg.dsh.de
Whole thread Raw
In response to Re: [HACKERS] Case statement ready?  ("Thomas G. Lockhart" <lockhart@alumni.caltech.edu>)
List pgsql-hackers
>
> > > If anyone has a chance to look at the new code wrt the rewriter
> >     Did it add new node types? If not, the rewrite  system  might
> >     already be happy with it. Anyway - I'll take a look at it and
> >     check/extend/fix for the rewrite corner.
>
> Yes, it added new node types (CaseExpr and CaseWhen), and I added a few
> lines to rewriteHandler.c to pretty much ignore them. Not sure if that
> was the right thing to do.

    I expect that the structures below the two new nodes can also
    contain Var nodes. And then it's definitely wrong  to  ignore
    them.   They  must  be handled properly in rewriteHandler and
    rewriteManip.


Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#======================================== jwieck@debis.com (Jan Wieck) #

pgsql-hackers by date:

Previous
From: Eildert Groeneveld
Date:
Subject: memory leak?
Next
From: Constantin Teodorescu
Date:
Subject: PgAccess stable version 0.92 released !