Re: Selectively invalidate caches in pgoutput module - Mailing list pgsql-hackers

Hi,

On 2025-03-13 14:13:39 +0530, Amit Kapila wrote:
> On Wed, Mar 12, 2025 at 5:46 PM Hayato Kuroda (Fujitsu)
> <kuroda.hayato@fujitsu.com> wrote:
> >
> > > Thanks, the patch looks mostly good to me. I have made few cosmetic
> > > changes in the attached and combined both the patches.
> >
> > Thanks, it looks good to me.
> >
> > > The existing
> > > Alter Publication ... Rename tests don't test invalidations arising
> > > from that command. As this patch changes that code path, it would be
> > > good to add a few tests for the same. We can add one for individual
> > > relations and another for ALL Tables publication.
> >
> > I created new patch which adds a test code.
> >
>
> Thanks. I have pushed the patch after minor changes in the test.

I think the new tests just failed in CI:
https://cirrus-ci.com/task/5602950271205376?logs=test_world#L268

[13:34:38.562] ――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
[13:34:38.562] stderr:
[13:34:38.562] #   Failed test 'check replication worked well before renaming a publication'
[13:34:38.562] #   at /tmp/cirrus-ci-build/src/test/subscription/t/007_ddl.pl line 93.
[13:34:38.562] #          got: ''
[13:34:38.562] #     expected: '1'
[13:34:38.562] #   Failed test 'check the tuple inserted after the RENAME was not replicated'
[13:34:38.562] #   at /tmp/cirrus-ci-build/src/test/subscription/t/007_ddl.pl line 110.
[13:34:38.562] #          got: ''
[13:34:38.562] #     expected: '1'
[13:34:38.562] # Looks like you failed 2 tests of 8.
[13:34:38.562]
[13:34:38.562] (test program exited with status code 2)
[13:34:38.562] ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
[13:34:38.562]

Greetings,

Andres Freund