Small stylistic change - Mailing list pgsql-patches

From Manfred Koizar
Subject Small stylistic change
Date
Msg-id hnal1vshse46f0t6vhsnago0jh0htgjdgd@4ax.com
Whole thread Raw
Responses Re: Small stylistic change
Re: Small stylistic change
List pgsql-patches
Rewrite for-loop, because this is not the Obfuscated C Code Contest.

Servus
 Manfred
diff -ruN ../base/src/backend/storage/page/bufpage.c ./src/backend/storage/page/bufpage.c
--- ../base/src/backend/storage/page/bufpage.c    2002-09-04 22:31:26.000000000 +0200
+++ ./src/backend/storage/page/bufpage.c    2003-01-06 18:07:09.000000000 +0100
@@ -409,8 +409,7 @@
     unsigned    offset;
     int            nbytes;
     int            offidx;
-    int            nline,
-                i;
+    int            nline;

     /*
      * As with PageRepairFragmentation, paranoia seems justified.
@@ -479,11 +478,12 @@
      */
     if (!PageIsEmpty(page))
     {
+        int i;
         nline--;                /* there's one less than when we started */
-        for (i = nline; --i >= 0;)
+        for (i = 1; i <= nline; i++)
         {
-            if (PageGetItemId(phdr, i + 1)->lp_off <= offset)
-                PageGetItemId(phdr, i + 1)->lp_off += size;
+            if (PageGetItemId(phdr, i)->lp_off <= offset)
+                PageGetItemId(phdr, i)->lp_off += size;
         }
     }
 }

pgsql-patches by date:

Previous
From: Manfred Koizar
Date:
Subject: Typos
Next
From: Jon Jensen
Date:
Subject: Re: Refuse SSL patch