Re: Apply worker can pick an invalid index for REPLICA IDENTITY FULL lookups - Mailing list pgsql-hackers

From Miłosz Bieniek
Subject Re: Apply worker can pick an invalid index for REPLICA IDENTITY FULL lookups
Date
Msg-id hk0VDsTA5u9qpkWkHFRYqsbvbHElAFvnYiCHLkP_jfzn8qtPmVREsLTaV2HeJ0TX935yz3nTVlat-FkZi3TlLjwVtawbGFwN4BSfYNBFzT0=@proton.me
Whole thread
In response to Apply worker can pick an invalid index for REPLICA IDENTITY FULL lookups  (Mihail Nikalayeu <mihailnikalayeu@gmail.com>)
List pgsql-hackers
> I initially thought about that approach too, but an assertion also
> uses that check.
> This is explained in the commit message:
>
> > Skip invalid indexes, as the planner does.  The test belongs here rather
> > than in IsIndexUsableForReplicaIdentityFull(), whose other caller is an
> > assertion that would then trip over an index DROP INDEX CONCURRENTLY has
> > just invalidated but that still finds tuples fine.

Oh sorry, I didn't notice it. Make sense.

I was wondering if there is a way (and whether it even makes sens
to make this test fail faster?
Right now, if we remove `idxRel->rd_index->indisvalid &&` the test
just hangs until the overall timeout is hit and we're not getting
any meaningful message.

Kind regards,
Miłosz Bieniek




pgsql-hackers by date:

Previous
From: "Greg Burd"
Date:
Subject: Re: Add bms_offset_members() function for bitshifting Bitmapsets
Next
From: Diego
Date:
Subject: Re: [Proposal] add portaddr like hostaddr