Re: Enable -Wstrict-prototypes and -Wold-style-definition by default - Mailing list pgsql-hackers

The first three patches have been committed.

On 24.03.26 08:16, Bertrand Drouvot wrote:
> 0004:
> 
> --- a/meson.build
> +++ b/meson.build
> @@ -2199,6 +2199,7 @@ unroll_loops_cflags = cc.get_supported_arguments(['-funroll-loops'])
>   
>   common_warning_flags = [
>     '-Wmissing-prototypes',
> +  '-Wold-style-declaration',
> 
> Nit, what about adding it with (as the comment is also accurate for the new one)?
> 
> "
> # These are C-only flags, supported in all C11-capable GCC/Clang versions.
> cflags_warn += cc.get_supported_arguments(['-Wstrict-prototypes', '-Wold-style-definition'])
> "

Yeah, makes sense to collect the C-only flags together.  But now that 
I'm looking at this again, the comment "supported in all C11-capable 
GCC/Clang versions" is not relevant here, it was only relevant in 
configure.ac because there we don't actually test for these flags but 
require them without testing.  What do you think about the attached 
patch, which reorganizes this a bit more?