Re: Align memory context level numbering in pg_log_backend_memory_contexts() - Mailing list pgsql-hackers

From torikoshia
Subject Re: Align memory context level numbering in pg_log_backend_memory_contexts()
Date
Msg-id fe60f073a7f646239f1a273f21bebf03@oss.nttdata.com
Whole thread Raw
In response to Re: Align memory context level numbering in pg_log_backend_memory_contexts()  (Rahila Syed <rahilasyed90@gmail.com>)
List pgsql-hackers
Thanks for your review, Melih and Rahila.

On 2025-04-17 21:25, Rahila Syed wrote:
> Hi,
> 
>> The attached patch is how I think we should do it.
> 
> Thank you for the patch.
> I tested this patch and it works fine. I agree with the changes made
> in it.
> 
> Regarding v2 patch,
> -                       int                     level = 0;
> 
> Retaining the level variable will enhance the code readability, IMO.

As for the level variable, this change comes from the v1 patch, and I 
don't have a strong opinion about it.
However, if we decide to keep the level variable here, it might be more 
consistent to also define it in MemoryContextStatsDetail().


-- 
Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: disabled SSL log_like tests
Next
From: Robert Haas
Date:
Subject: Re: pgsql: Add function to get memory context stats for processes