Re: [HACKERS] Time to drop old-style (V0) functions? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Time to drop old-style (V0) functions?
Date
Msg-id fe519f25-1b85-68ca-9be5-277de2e8a7c5@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Time to drop old-style (V0) functions?  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Time to drop old-style (V0) functions?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 12/9/16 7:52 AM, Robert Haas wrote:
> It's kind of ironic, at least IMHO, that the DirectionFunctionCall
> macros are anything but direct.  Each one is a non-inlined function
> call that does a minimum of 8 variable assignments before actually
> calling the function.

If this is a problem (it might be), then we can just make those calls,
er, direct C function calls to different function.  For example,
   result = DatumGetObjectId(DirectFunctionCall1(oidin,
CStringGetDatum(pro_name_or_oid)));

could just be
   result = oidin_internal(pro_name_or_oid);

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Minor correction in alter_table.sgml
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Time to drop old-style (V0) functions?