On 27/01/2026 14:51, Fujii Masao wrote:
> It looks like the short description for %i is missing from the header comment
> at the top of get_prompt(). Could you add that?
>
>
> In the patch, nothing is shown when connected to PostgreSQL 13 or older
> (i.e., versions that do not report in_hot_standby). Would it be better to
> show "?", similar to what %S does?
It seems I reverted too much from the previous patch :)
Description added again.
>
>
> + else
> + buf[0] = '\0';
> + }
> + else
> + buf[0] = '\0';
>
> The second "else + buf[0] = '\0'" does not seem necessary.
Here I was just following the style of other options, like %x
case 'x':
if (!pset.db)
buf[0] = '?';
Removed (let me know if I misunderstood your point here)
>
> + <listitem>
> + <para>
> + Indicates whether the server is in hot standby mode.
>
> The indentation style for "<para>" and its contents seems to differ from
> the surrounding prompt option descriptions. For consistency, it might be
> better to match the existing style used nearby.
Indentation fixed.
>
>
> + The value is shown as <literal>standby</literal> if the
> server reports
> + <literal>in_hot_standby</literal> as <literal>on</literal>,
>
> Would it be better to replace "<literal>in_hot_standby</literal>" with
> "<xref linkend="guc-in-hot-standby"/>"?
>
Yes, it's indeed much better. Replaced <literal>in_hot_standby</literal>
with <xref linkend="guc-in-hot-standby"/>.
> As with %S, it would be helpful to explicitly document what is shown when
> connected to PostgreSQL 13 or older. For example, something like:
>
> -----------------
> Indicates whether the connected server is running in hot standby mode.
> The value is shown as <literal>standby</literal> if the server is
> currently in hot standby and reports <xref
> linkend="guc-in-hot-standby"/> as <literal>on</literal>, and
> <literal>primary</literal> otherwise. This is useful when connecting
> to multiple servers to quickly determine the role of each connection.
> A value of <literal>?</literal> is shown when connected to a server
> running <productname>PostgreSQL</productname> 13 or older.
> -----------------
Added as you suggested.
Thanks for the quick review. Much appreciated!
Best, Jim
