Re: Show various offset arrays for heap WAL records - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Show various offset arrays for heap WAL records
Date
Msg-id fe32d2a0-0998-d866-d6ee-2aed70b9be00@iki.fi
Whole thread Raw
In response to Re: Show various offset arrays for heap WAL records  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
On 04/09/2023 23:02, Melanie Plageman wrote:
> I might phrase the last bit as "neither the description functions nor
> the output format should be considered part of a stable API"
> 
> +Guidelines for rmgrdesc output format
> +=====================================
> 
> I noticed you used === for both headings and wondered if it was
> intentional. Other READMEs I looked at in src/backend/access tend to
> have a single heading underlined with ==== and then subsequent
> headings are underlined with -----. I could see an argument either way
> here, but I just thought I would bring it up in case it was not a
> conscious choice.
> 
> Otherwise, LGTM.

Made these changes and committed. Thank you!

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: Pavel Borisov
Date:
Subject: Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound
Next
From: "Drouvot, Bertrand"
Date:
Subject: Replace (stat())[7] in TAP tests with -s