Re: Another small pl/perl patch - Mailing list pgsql-patches

From Greg Sabino Mullane
Subject Re: Another small pl/perl patch
Date
Msg-id fdfc8957c5dc4b263c8bd48c2f6fa903@biglumber.com
Whole thread Raw
In response to Re: Another small pl/perl patch  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Another small pl/perl patch
List pgsql-patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> Well, I personally almost always use indirect file handles rather than
> globals. But I don't know that using globals file handles (which is what
> I gather you are objecting to) is deprecated, is it? The perl docs are
> absolutely littered with examples.

No, my primary objection was using open() without checking the result.
Everything else was icing. :)

> (I also use BSD style intentation consistently across my C, perl and
> Java ... which is unusual at least in the latter 2 cases but works well
> for me ;-) )

I tried to match the indenting to what is already in the docs, which is
fairly close to my own style.

- --
Greg Sabino Mullane greg@turnstep.com
PGP Key: 0x14964AC8 200510241105
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8

-----BEGIN PGP SIGNATURE-----

iD8DBQFDXPhjvJuQZxSWSsgRAm6RAKD0RmrD5U5Uzv73wBVIfiCAIpAWewCg6XzJ
cPfuNaMX/gD+vA1VugR2YYo=
=va+e
-----END PGP SIGNATURE-----



pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Another small pl/perl patch
Next
From: Andrew Dunstan
Date:
Subject: Re: Another small pl/perl patch