Re: pgsql: Change gist stratnum function to use CompareType - Mailing list pgsql-committers

On 15.01.25 22:36, Melanie Plageman wrote:
> On Wed, Jan 15, 2025 at 5:41 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Change gist stratnum function to use CompareType
>>
>> This changes commit 7406ab623fe in that the gist strategy number
>> mapping support function is changed to use the CompareType enum as
>> input, instead of the "well-known" RT*StrategyNumber strategy numbers.
>>
>> This is a bit cleaner, since you are not dealing with two sets of
>> strategy numbers.  Also, this will enable us to subsume this system
>> into a more general system of using CompareType to define operator
>> semantics across index methods.
> 
> This appears to fail the headers_cpluspluscheck job in CI [1] with
> 
> /tmp/cirrus-ci-build/src/include/access/gist.h:251:63: error: use of
> enum ‘CompareType’ without previous declaration
> 251 | extern StrategyNumber GistTranslateStratnum(Oid opclass, enum
> CompareType cmp);

Fixed, thanks.