Re: Let's get rid of serial_schedule - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Let's get rid of serial_schedule
Date
Msg-id fb34bbd4-2155-0944-e3a2-ae8d0e0dd09d@iki.fi
Whole thread Raw
In response to Let's get rid of serial_schedule  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Let's get rid of serial_schedule
List pgsql-hackers
On 11/05/2021 21:58, Tom Lane wrote:
> We've several times discussed doing $SUBJECT by replacing the
> makefile's use of serial_schedule with calling parallel_schedule
> with --max-connections=1.  This'd remove the need to maintain
> two lists of regression test scripts.
> 
> I got annoyed again just now about how people seem unable to
> keep the two lists in the same order, so here is a patch to
> get rid of serial_schedule in that way.

+1

> +    # for backwards compatibility, interpret "serial" as parallel tests

This comment isn't great, IMHO. How about:

# for backwards comopatibility, "serial" runs the tests in
# parallel_schedule one by one.

- Heikki



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Let's get rid of serial_schedule
Next
From: Joe Conway
Date:
Subject: Re: PG 14 release notes, first draft