Re: COMMENTS are not being copied in CREATE TABLE LIKE - Mailing list pgsql-hackers

From Jim Jones
Subject Re: COMMENTS are not being copied in CREATE TABLE LIKE
Date
Msg-id f9d90b0b-d57c-4887-968b-31b399d05942@uni-muenster.de
Whole thread Raw
In response to Re: COMMENTS are not being copied in CREATE TABLE LIKE  (Carlos Alves <carlos@alves.inf.br>)
List pgsql-hackers
Hi Carlos

On 26/03/2026 18:59, Carlos Alves wrote:
> No errors or failures were detected during the tests.
> 
> The only suggestion is to keep the parameter description a single paragraph, following the same style as the
descriptionof the other inclusion parameters. But the current description is coherent and okay.
 
> 
> After the tests, the patch is working as expected:
> - Table-level comments are copied when the `including comments` parameter is used.
> - When there is more than one source table, comments, if any, are kept in the order in which they appear in the
command,separated by a new line.
 
> - The performance of command execution was not affected.
> 
> I think only the code review is missing, but I don't have much experience to perform this step.


Thanks for this thorough review. This helps a lot!
Let's see what the other reviewers have to say about the code and your
docs suggestion.

Best, Jim




pgsql-hackers by date:

Previous
From: Carlos Alves
Date:
Subject: Re: COMMENTS are not being copied in CREATE TABLE LIKE
Next
From: Jeff Davis
Date:
Subject: Re: Use correct collation in pg_trgm