Re: Commitfest 2021-11 Patch Triage - Part 1 - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: Commitfest 2021-11 Patch Triage - Part 1
Date
Msg-id f9a6f56c-8958-3c25-2976-e3262167172d@enterprisedb.com
Whole thread Raw
In response to Re: Commitfest 2021-11 Patch Triage - Part 1  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers

On 12/2/21 12:06, Daniel Gustafsson wrote:
>> On 6 Nov 2021, at 17:20, Tomas Vondra <tomas.vondra@enterprisedb.com> wrote:
>>
>> On 11/5/21 22:15, Daniel Gustafsson wrote:
>>> ...
>>> 1651: GROUP BY optimization
>>> ===========================
>>> This is IMO a desired optimization, and after all the heavy lifting by Tomas
>>> the patch seems to be in pretty good shape.
>>
>> I agree it's desirable. To move the patch forward, I need some feedback on the costing questions, mentioned in my
lastreview, and the overall approach to planning (considering multiple group by variants).
 
> 
> I'm moving this to the next CF with the hope that more feedback is received.
> If you think "Ready for Committer" is a more suitable status, please do update
> it as I'm leaving it in Needs Review for now not having the full context.

I don't think anyone reviewed the costing, so I think "needs review" is 
appropriate.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: PATCH: generate fractional cheapest paths in generate_orderedappend_path
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_dump versus ancient server versions