Re: Exclude schema during pg_restore - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Exclude schema during pg_restore
Date
Msg-id f8948108-4a72-fe46-97b5-fba7b13d72f7@2ndquadrant.com
Whole thread Raw
In response to Exclude schema during pg_restore  (Michael Banck <mbanck@gmx.net>)
Responses Re: Exclude schema during pg_restore  (Michael Banck <michael.banck@credativ.de>)
Re: Exclude schema during pg_restore  (Michael Banck <michael.banck@credativ.de>)
List pgsql-hackers
On 8/31/16 4:10 AM, Michael Banck wrote:
> attached is a small patch that adds an -N option to pg_restore, in order
> to exclude a schema, in addition to -n for the restriction to a schema.

I think this is a good idea, and the approach looks sound.  However,
something doesn't work right.  If I take an empty database and dump it,
it will dump the plpgsql extension.  If I run pg_dump in plain-text mode
with -N, then the plpgsql extension is also dumped (since it is not in
the excluded schema).  But if I use the new pg_restore -N option, the
plpgsql extension is not dumped.  Maybe this is because it doesn't have
a schema, but I haven't checked.

pg_dump does not apply --strict-names to -N, but your patch for
pg_restore does that.  I think that should be made the same as pg_dump.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: restoration after crash slowness, any way to improve?
Next
From: Craig Ringer
Date:
Subject: Re: [PATCH] COPY vs \copy HINT