Re: Crash issue in PG18.5 regression - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Crash issue in PG18.5 regression
Date
Msg-id f72a8fbe-7ef1-4cd3-8a4b-fd9106480510@iki.fi
Whole thread
In response to Re: Crash issue in PG18.5 regression  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Crash issue in PG18.5 regression
List pgsql-hackers
On 11/08/2026 12:19, Heikki Linnakangas wrote:
> I think the best fix is to make pg_strupper() in REL_18_STABLE also work 
> with the C locale. It's an accident waiting to happen if it doesn't. 
> (And same for all the other pg_str*() functions, of course)

Like the attached.

There's some code duplication: the strupper_c() function is essentially 
the same as asc_toupper(), and str_toupper() wouldn't really need to 
have the special case for C locale anymore, it could just rely on 
pg_strupper() now. But that's so in 'master' too, so I think cleaning 
that up should be left for a separate patch.

- Heikki

Attachment

pgsql-hackers by date:

Previous
From: "Yilin Zhang"
Date:
Subject: Re: Per-table resync for logical replication subscriptions
Next
From: Nikhil Sontakke
Date:
Subject: Stale comments for the tuple_update/tuple_delete options parameter