Re: DROP SUBSCRIPTION with no slot - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: DROP SUBSCRIPTION with no slot
Date
Msg-id f5d48b96-f135-efad-a1d1-369984c7d18b@2ndquadrant.com
Whole thread Raw
In response to DROP SUBSCRIPTION with no slot  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: DROP SUBSCRIPTION with no slot
Re: DROP SUBSCRIPTION with no slot
List pgsql-hackers
On 2019-09-24 16:31, Jeff Janes wrote:
> I recently had to cut loose (pg_drop_replication_slot) a logical replica
> that couldn't keep up and so was threatening to bring down the master.
> 
> In mopping up on the replica side, I couldn't just drop the
> subscription, because it couldn't drop the nonexistent slot on the
> master and so refused to work.  So I had to do a silly little dance
> where I first disable the subscription, then ALTER SUBSCRIPTION ... SET
> (slot_name = NONE), then drop it.
> 
> Wanting to clean up after itself is admirable, but if there is nothing
> to clean up, why should that be an error condition?

The alternatives seem quite error prone to me.  Better be explicit.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Improving on MAX_CONVERSION_GROWTH
Next
From: Andrew Dunstan
Date:
Subject: Release 11 of PostgreSQL Buildfarm client