Re: Outdated replication protocol error? - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Outdated replication protocol error?
Date
Msg-id f472e434-c10e-0dc0-2554-c05f745f2a2d@oss.nttdata.com
Whole thread Raw
In response to Outdated replication protocol error?  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: Outdated replication protocol error?  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers

On 2021/01/12 9:06, Jeff Davis wrote:
> Commit 5ee2197767 (about 4 years old) introduced the error:
> 
>    "IDENTIFY_SYSTEM has not been run before START_REPLICATION"
> 
> But it seems like running START_REPLICATION first works (at least in
> the simple case).
> 
> We should either:
> 
> 1. Document that IDENTIFY_SYSTEM must always be run before
> START_REPLICATION, and always issue a WARNING if that's not done (an
> ERROR might break existing applications); or
> 
> 2. If the commit is out of date and no longer needed, or if it's easy
> enough to fix, just remove the error (and Assert a valid
> ThisTimeLineID).

+1 to remove the error if START_REPLICATION can always work fine without
IDENTIFY_SYSTEM. I found that the error happens when we connect to the standby
and just run START_REPLICATION without IDENTIFY_SYSTEM. But I'm not sure
if IDENTIFY_SYSTEM is actually necessary even in that case.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Fix typo about WalSndPrepareWrite
Next
From: Sergey Shinderuk
Date:
Subject: Re: pg_preadv() and pg_pwritev()