Request a Demo
Home   >   mailing lists

Re: Move system identifier generation to a common helper - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Move system identifier generation to a common helper
Date
Msg-id f449b482-75e1-4678-9dd0-5fe03a0004e4@eisentraut.org
Whole thread
In response to Move system identifier generation to a common helper  (Imran Zaheer <imran.zhir@gmail.com>)
Responses Re: Move system identifier generation to a common helper
List pgsql-hackers
Tree view 
On 04.06.26 14:22, Imran Zaheer wrote:
> The code used to generate a new system identifier is duplicated in
> multiple locations, including BootStrapXLOG(), pg_createsubscriber, and
> pg_resetwal.
> 
> Move the generation logic into a common GenerateSystemIdentifier()
> helper so that all callers use a single implementation, avoiding
> duplication of the same algorithm.

Then again, this code is from PG 8.0.  We have had pg_strong_random() 
required since PG 12.  Maybe we should use that now for this.

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Improve version detection for online help URL
Next
From: "ZizhuanLiu X-MAN"
Date:
Subject: Re: Return value of XLogInsertRecord() for XLOG_SWITCH record