Re: [COMMITTERS] pgsql: Add function to import operating systemcollations - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: [COMMITTERS] pgsql: Add function to import operating systemcollations
Date
Msg-id f34dbd10-932b-eabf-86c6-eb692d0bfc57@2ndquadrant.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add function to import operating system collations  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 1/19/17 11:58 AM, Tom Lane wrote:
> Stephen Frost <sfrost@snowman.net> writes:
>> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>>> WFM.  Btw, I noticed that BOOTSTRAP_SUPERUSERID is hard-coded as "10"
>>> in this bit in setup_privileges():
>
>> Hm.  I seem to recall trying to avoid having the hard-coded value there
>> but we don't have BOOTSTRAP_SUPERUSERID defined somewhere that initdb.c
>> could include it from, do we?  It's only in catalog/pg_authid.h.
>
> Looks to me like including catalog/pg_authid.h in initdb would work fine.
> pg_upgrade does it.

I have fixed that together with Amit's issue.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: initdb: Fix for mixed-case superuser names
Next
From: Alvaro Herrera
Date:
Subject: [COMMITTERS] pgsql: Fix race condition in reading commit timestamps