Re: [PATCH] postgres_fdw extension support - Mailing list pgsql-hackers

From Paul Ramsey
Subject Re: [PATCH] postgres_fdw extension support
Date
Msg-id etPan.5613bdec.8138641.f3d@Crane.local
Whole thread Raw
In response to Re: [PATCH] postgres_fdw extension support  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
 
On October 4, 2015 at 9:56:10 PM, Michael Paquier (michael.paquier@gmail.com(mailto:michael.paquier@gmail.com)) wrote:
> On Sun, Oct 4, 2015 at 11:40 AM, Paul Ramsey wrote:
> > I put all changes relative to your review here if you want a nice colorized
> > place to check
> >
> > https://github.com/pramsey/postgres/commit/ed33e7489601e659f436d6afda3cce28304eba50
>
> - /* updatable is available on both server and table */
> + /* updatable option is available on both server and table */
> This is just noise (perhaps I am the one who introduced it, oops).

No, I did, it matches the change to the comment below that addresses Andres note. The principle of least change is
buttingup against the principle of language usage consistency here. Can remove, of course. 

P 


--
http://postgis.net
http://cleverelephant.ca





pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [Proposal] Table partition + join pushdown
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] postgres_fdw extension support