Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements - Mailing list pgsql-hackers

From Pavlo Golub
Subject Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
Date
Msg-id em5be966c3-9086-4f3f-b516-97444b854fdf@10e48d49.com
Whole thread Raw
In response to Re: [PATCH] Add last_executed timestamp to pg_stat_statements  (Sami Imseih <samimseih@gmail.com>)
Responses Re: Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
List pgsql-hackers
Hi


>Hi,
>
>Thanks for raising this. I did not look at the patch, but I have some high
>level comments.
>
>>  I would like to propose adding a last_executed timestamptz column to
>>  pg_stat_statements. This column records when each tracked statement
>>  was most recently executed.
>
>I do think there is value in adding a last_executed timestamp.

Thanks for your support!

>Can pg_stat_statements.stats_since help here?
>
>for example "where stats_since > last_poll_timestamp" ?

Actually no, monitoring tools fetch snapshots to find the difference
between snapshots.
Data for every statement is changes after each execution.

But stats_since is inserted only once when the new statement execution
appears and is never updated during next executions.

>
>
>The client does have to track the last_poll_timestamp in that
>case.
>
>[0] https://www.postgresql.org/message-id/flat/CAA5RZ0s9SDOu+Z6veoJCHWk+kDeTktAtC-KY9fQ9Z6BJdDUirQ@mail.gmail.com
>[1] https://www.postgresql.org/message-id/03f82e6f-66a3-4c4d-935c-ea4d93871dc1%40gmail.com
>
>--
>Sami Imseih
>Amazon Web Services (AWS)



pgsql-hackers by date:

Previous
From: Ajit Awekar
Date:
Subject: Re: Periodic authorization expiration checks using GoAway message
Next
From: shveta malik
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication