Request a Demo
Home   >   mailing lists

Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements - Mailing list pgsql-hackers

From Pavlo Golub
Subject Re[2]: [PATCH] Add last_executed timestamp to pg_stat_statements
Date
Msg-id em462c0bc8-4dcd-4c36-b416-e3bc194fa770@cybertec.at
Whole thread Raw
In response to Re: [PATCH] Add last_executed timestamp to pg_stat_statements  (Christoph Berg <myon@debian.org>)
List pgsql-hackers
Tree view 
>
>Is this extra complexity worth one saved GetCurrentTimestamp()?

I'm not sure really. But I really need a new column in one way or
another, so I can agree to whatever decision we'll make.
>
>
>src/backend/access/transam/xact.c is calling GetCurrentTimestamp a
>lot already, so I don't really buy the argument it should be avoided
>at all cost in pg_stat_statements. Just storing the statement end time
>would make this use case much nicer.
+1

Maybe just move GetCurrentTimestamp outside of spin lock is engouh
already?

>
>
>Christoph

pgsql-hackers by date:

Previous
From: Sugamoto Shinya
Date:
Subject: Re: [PATCH] Add error hints for invalid COPY options
Next
From: "Matheus Alcantara"
Date:
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row