Hi,
On 4/6/23 8:40 AM, Amit Kapila wrote:
> On Wed, Apr 5, 2023 at 9:27 PM Drouvot, Bertrand
>
> After this, I think for backends that have active slots, it would
> simply cancel the current query. Will that be sufficient? Because we
> want the backend process should exit and release the slot so that the
> startup process can mark it invalid.
> For walsender, an ERROR will lead
> to its exit, so that is fine. If this understanding is correct, then
> if 'am_cascading_walsender' is false, we should set ProcDiePending
> apart from other parameters. Sorry, I haven't tested this, so I could
> be wrong here.
Oops my bad. You are fully, right. Fixed in V62 posted up-thread
> Also, it seems you have removed the checks related to
> slots, is it because PROCSIG_RECOVERY_CONFLICT_LOGICALSLOT is only
> used for logical slots? If so, do you think an Assert would make
> sense?
>
Yes, indeed adding an Assert makes sense: done in V62 posted up-thread.
> Another comment on 0001.
> extern void CheckSlotRequirements(void);
> extern void CheckSlotPermissions(void);
> +extern void ResolveRecoveryConflictWithLogicalSlots(Oid dboid,
> TransactionId xid, char *reason);
>
> This doesn't seem to be called from anywhere.
>
Good catch, removed in V62 posted up-thread.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
