Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Date
Msg-id ee1d403c-37c8-2e11-a785-278d76f4cd8e@oss.nttdata.com
Whole thread Raw
In response to RE: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit  ("Hou, Zhijie" <houzj.fnst@cn.fujitsu.com>)
List pgsql-hackers

On 2021/01/19 9:53, Hou, Zhijie wrote:
>>>>> +1 to add it after "dropped (Note ........)", how about as follows
>>>>> with slight changes?
>>>>>
>>>>> dropped (Note that server name of an invalid connection can be NULL
>>>>> if the server is dropped), and then such .....
>>>>
>>>> Yes, I like this one. One question is; "should" or "is" is better
>>>> than "can" in this case because the server name of invalid connection
>>>> is always NULL when its server is dropped?
>>>
>>> I think "dropped (Note that server name of an invalid connection will
>>> be NULL if the server is dropped), and then such ....."
>>
>> Sounds good to me. So patch attached.
> 
> +1

Thanks! I pushed the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: CheckpointLock needed in CreateCheckPoint()?
Next
From: Tom Lane
Date:
Subject: Re: [PATCH 1/1] Initial mach based shared memory support.