On 2025-10-01 We 8:27 AM, Nazir Bilal Yavuz wrote:
> Hi,
>
> On Wed, 1 Oct 2025 at 15:09, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
>> On Tue, 30 Sept 2025 at 22:48, Andrew Dunstan <andrew@dunslane.net> wrote:
>>> Hi Bilal,
>>>
>>> This got preempted slightly by Tom's commit 170a8a3f460, but I think
>>> it's worth doing. I tried to simplify it some. See attached. There
>>> doesn't seem to me to be any point in using a different set of files for
>>> the tab tests and the NBSP tests. If we use the same set of files we can
>>> improve the efficiency easily by opening them only once. Here we just
>>> look for all the sgml files and all the xsl files and process them all.
>>>
>>> WDYT?
>> It looks good to me. I made 2 changes to your patch:
>>
>> 1- Declaration of $line_no is lost, I re-added it.
>> 2- s/.cirrus.tasks,yml/.cirrus.tasks.yml/ in the commit message.
> Two more minor changes that I missed in the v2:
>
> 1- I added $line_no and removed $_ from the tab check's warning
> message. I think it is better this way, otherwise if the line only
> contains tab character; $_ will print an empty looking line.
> 2- s/Tabsand/Tabs and/
>
OK, thanks, looks good. How do we go about doing what Tom wants (i.e.
running the tests by default) under meson. I think in the Makefile we
could just add it to the html target.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
