Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vslookups - Mailing list pgsql-hackers

On 12/29/16 4:28 AM, Craig Ringer wrote:
> On 29 December 2016 at 16:51, Craig Ringer <craig@2ndquadrant.com> wrote:
>> On 28 December 2016 at 22:16, Petr Jelinek <petr.jelinek@2ndquadrant.com> wrote:
>>
>>> About the patch, it looks good to me for master with the minor exception
>>> that:
>>>> +             appendStringInfo(buf, "pageno %d, xid %u",
>>>> +                     trunc.pageno, trunc.oldestXid);
>>>
>>> This should probably say oldestXid instead of xid in the text description.
>>
>> Agreed.
> 
> Slightly amended attached.

I've looked over this.  It looks correct to me in principle.

The commit message does not actually explain how the race on the standby
is fixed by the patch.

Also, I wonder whether we should not in vacuum.c change the order of the
calls of SetTransactionIdLimit() and SetMultiXactIdLimit() as well, just
to keep everything consistent.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services