Re: Allow tests to pass in OpenSSL FIPS mode - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Allow tests to pass in OpenSSL FIPS mode
Date
Msg-id e9b48520-ad90-7edf-04ce-e8f8a7eea90d@enterprisedb.com
Whole thread Raw
In response to Re: Allow tests to pass in OpenSSL FIPS mode  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Allow tests to pass in OpenSSL FIPS mode  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On 06.03.23 17:06, Daniel Gustafsson wrote:
>> On 6 Mar 2023, at 15:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Daniel Gustafsson <daniel@yesql.se> writes:
> 
>>> For readers without all context, wouldn't it be better to encode in the
>>> function name why we're not just calling a hash like md5?  Something like
>>> fips_allowed_hash() or similar?
>>
>> I'd prefer shorter than that --- all these queries are laid out on the
>> expectation of a very short function name.  Maybe "fipshash()"?
>>
>> We could make the comment introducing the function declarations more
>> elaborate, too.
> 
> fipshash() with an explanatory comments sounds like a good idea.

committed like that

(I'm going to close the CF item and revisit the other test suites for 
the next release.)



pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: [BUG] pg_stat_statements and extended query protocol
Next
From: Daniel Gustafsson
Date:
Subject: Re: Allow tests to pass in OpenSSL FIPS mode