On 11.04.23 19:18, Andres Freund wrote:
>> Subject: [PATCH v9 2/5] Add data layout options sub-section in installation
>> docs
>>
>> This commit separates out blocksize, segsize and wal_blocksize
>> options into a separate Data layout options sub-section in both
>> the make and meson docs. They were earlier in a miscellaneous
>> section which included several unrelated options. This change
>> also helps reduce the repetition of the warnings that changing
>> these parameters breaks on-disk compatibility.
>
> Makes sense. I'm planning to apply this unless Peter or somebody else has
> further feedback.
I'm okay with patches 0001 through 0004.
I don't like 0005. I think we should drop that for now and maybe have a
separate discussion under a separate heading about that.
>
>
>> From 11d82aa49efb3d1cbc08f14562a757f115053c8b Mon Sep 17 00:00:00 2001
>> From: Samay Sharma <smilingsamay@gmail.com>
>> Date: Mon, 13 Feb 2023 16:23:52 -0800
>> Subject: [PATCH v9 3/5] Remove Anti-Features section from Installation from
>> source docs
>>
>> Currently, several meson setup options are listed in anti-features.
>> However, they are similar to most other options in the postgres
>> features list as they are 'auto' features themselves. Also, other
>> options are likely better suited to the developer options section.
>> This commit, therefore, moves the options listed in the anti-features
>> section into other sections and removes that section.
>>
>> For consistency, this reorganization has been done on the make section
>> of the docs as well.
>
> Makes sense to me. "Anti-Features" is confusing as a name to start with.
