Re: btree_gin and btree_gist for enums - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: btree_gin and btree_gist for enums
Date
Msg-id e60f50c4-899a-d48a-6cb4-4611acf2f73c@dunslane.net
Whole thread Raw
In response to Re: btree_gin and btree_gist for enums  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: btree_gin and btree_gist for enums
List pgsql-hackers

On 11/05/2016 11:46 AM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> The real problem here is that enum_cmp_internal assumes that
>> fcinfo->flinfo has been set up, and DirectFunctionCallN doesn't, it sets
>> it to NULL.
>> The patch below cures the problem. I'm not sure if there is a better
>> way. Thoughts?
> That may be a good fix for robustness purposes, but it seems pretty horrid
> from an efficiency standpoint.  Where is this call, and should we be
> modifying it to provide a flinfo?
>
>


See attached updated patch that adds enum support to btree_gist and
btree_gin

I thought of providing an flinfo, but I couldn't see a simple way to do
it that would provide something much longer lived than the function
call, in which case it seemed a bit pointless. That's why I asked for
assistance :-)

cheers

andrew

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: MinSizeOfXactInvals defined twice
Next
From: Steve Singer
Date:
Subject: Re: Logical Replication WIP