Re: RESET command seems pretty disjointed now - Mailing list pgsql-hackers

From Marko Kreen
Subject Re: RESET command seems pretty disjointed now
Date
Msg-id e51f66da0704240804q59bc280dy4bb129d2eac407fa@mail.gmail.com
Whole thread Raw
In response to Re: RESET command seems pretty disjointed now  (Neil Conway <neilc@samurai.com>)
Responses Re: RESET command seems pretty disjointed now  (Neil Conway <neilc@samurai.com>)
Re: RESET command seems pretty disjointed now  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On 4/23/07, Neil Conway <neilc@samurai.com> wrote:
> On Tue, 2007-04-17 at 16:34 +0300, Marko Kreen wrote:
> > Attached patch does following conversions:
>
> ISTM it would be cleaner to use an enum to identify the different
> variants of the DISCARD command, rather than a character string.
>
> Is guc.c still the logical place for the implementation of DISCARD?
> Something under backend/commands might be better, although I don't see a
> real obvious place for it.
>
> The psql tab completion code requires updating for the new DISCARD
> command.

Attached patch addresses all 3 comments.  As it will be
top-level command, I put code into commands/discard.c

--
marko

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: tsearch2 in 8.3
Next
From: Tom Lane
Date:
Subject: Re: [BUGS] BUG #3245: PANIC: failed to re-find shared loc k o b j ect