Re: RESET command seems pretty disjointed now - Mailing list pgsql-hackers

From Marko Kreen
Subject Re: RESET command seems pretty disjointed now
Date
Msg-id e51f66da0704170003w4b6044ffmc385c37e7702264a@mail.gmail.com
Whole thread Raw
In response to Re: RESET command seems pretty disjointed now  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: RESET command seems pretty disjointed now  ("Marko Kreen" <markokr@gmail.com>)
List pgsql-hackers
On 4/17/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Florian Pflug <fgp.phlo.org@gmail.com> writes:
> > Tom Lane wrote:
> >>> The current documentation for RESET exhibits a certain lack of, um,
> >>> intellectual cohesiveness:
>
> > What about
> > RESET parameter
> > RESET { PLANS | TEMP | TEMPORARY }
> > RESET ALL { PARAMETERS | STATE }
>
> > RESET ALL would become an abbreviation of RESET ALL PARAMETERS (for backwards
> > compatibility), while RESET SESSION would be renamed to RESET ALL STATE.
>
> This doesn't do anything to address the lack of coherence.  It's not
> only that backward compatibility forces us to break the clear meaning of
> ALL; another problem is that we break the symmetry between SET, RESET,
> and SHOW.  If you can RESET SESSION, what does it mean to SET SESSION?
> Or SHOW SESSION?
>
> Given the precedent that RESET ALL only resets GUC variables, I think
> it's probably best if we just say that RESET only affects GUC variables,
> period.  The new functionality should go by another name entirely.
> I'm not wedded to DISCARD by any means, but I do not believe that
> changing some words after RESET is going to fix my complaint.

Can't argue with that.  Also I don't have better proposals.
If DISCARD is the final word, I start to prepare a patch.

-- 
marko


pgsql-hackers by date:

Previous
From: Kris Jurka
Date:
Subject: Re: Hacking on PostgreSQL via GIT
Next
From: "Islam Hegazy"
Date:
Subject: modifying the table function