Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH]Feature improvement for MERGE tab completion - Mailing list pgsql-hackers

From bt22kawamotok
Subject Re: [PATCH]Feature improvement for MERGE tab completion
Date
Msg-id e4993887d2896d5a334d62257fe7f25b@oss.nttdata.com
Whole thread Raw
In response to Re: [PATCH]Feature improvement for MERGE tab completion  (Shinya Kato <Shinya11.Kato@oss.nttdata.com>)
Responses Re: [PATCH]Feature improvement for MERGE tab completion
List pgsql-hackers
Tree view 
> When I tried to apply this patch, I got the following warning, please 
> fix it.
> Other than that, I think everything is fine.
> 
> $ git apply fix_tab_completion_merge_v4.patch
> fix_tab_completion_merge_v4.patch:38: trailing whitespace.
>         else if (TailMatches("USING", MatchAny, "ON", MatchAny) ||
> fix_tab_completion_merge_v4.patch:39: indent with spaces.
>                  TailMatches("USING", MatchAny, "AS", MatchAny, "ON",
> MatchAny) ||
> fix_tab_completion_merge_v4.patch:40: indent with spaces.
>                  TailMatches("USING", MatchAny, MatchAny, "ON", 
> MatchAny))
> fix_tab_completion_merge_v4.patch:53: trailing whitespace.
>         else if (TailMatches("WHEN", "MATCHED") ||
> warning: 4 lines add whitespace errors.

Thanks for reviewing.

I fixed the problem and make patch v5.
Please check it.

Regards,

Kotaro Kawamoto
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: failing to build preproc.c on solaris with sun studio
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: why can't a table be part of the same publication as its schema