Re: [PATCH] Add inline comments to the pg_hba_file_rules view - Mailing list pgsql-hackers

From Jim Jones
Subject Re: [PATCH] Add inline comments to the pg_hba_file_rules view
Date
Msg-id e42ed34a-8d07-c4bd-61d3-cb4ee5a79906@uni-muenster.de
Whole thread Raw
In response to Re: [PATCH] Add inline comments to the pg_hba_file_rules view  (David Zhang <david.zhang@highgo.ca>)
List pgsql-hackers
Hi David

On 09.09.23 01:52, David Zhang wrote:
> This is a very useful feature. I applied the patch to the master 
> branch, and both make check and make check-world passed without any 
> issues.
>
Thanks for reviewing this patch!

>
> Since "only the first #" and "any leading spaces" are removed, IMO, it 
> can be more accurate to say,
>
> Text after the first <literal>#</literal> comment character in the end 
> of a valid <literal>pg_hba.conf</literal> entry, if any
>
I agree.

v2 attached includes your suggestion. Thanks!

Jim

Attachment

pgsql-hackers by date:

Previous
From: David Steele
Date:
Subject: Re: Add const qualifiers
Next
From: Tom Lane
Date:
Subject: Re: BUG #18097: Immutable expression not allowed in generated at